Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): bump babel packages #20430

Merged
merged 2 commits into from
Jan 6, 2020
Merged

chore(gatsby): bump babel packages #20430

merged 2 commits into from
Jan 6, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jan 6, 2020

  • Cleans up the yarn lock file (there were changes in package.json which were not reflected in the lock file which we were seeing in various new PR's)
  • Bump three Babel packages to a new patch version

@pvdz pvdz requested a review from a team as a code owner January 6, 2020 13:59
@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 6, 2020
m-allanson
m-allanson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pvdz
Copy link
Contributor Author

pvdz commented Jan 6, 2020

Double checked with @blainekasten that the reported error is not on this diff (it was complaining about a babel TS plugin). Going ahead.

@pvdz pvdz merged commit fd248d0 into master Jan 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the unlock-the-yarn branch January 6, 2020 15:16
vladar
vladar reviewed Jan 6, 2020
View reviewed changes
package.json
"@babel/runtime": "^7.7.6",
"@babel/core": "^7.7.7",
"@babel/node": "^7.7.7",
"@babel/runtime": "^7.7.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not upgrade anymore 🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar left review comments

@m-allanson m-allanson m-allanson approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdz @vladar @m-allanson