Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-starter-resume-cms #20423

Merged
merged 4 commits into from
Jan 6, 2020
Merged

chore(starters): add gatsby-starter-resume-cms #20423

merged 4 commits into from
Jan 6, 2020

Conversation

barancezayirli
Copy link
Contributor

Description

It is a resume/CV starter with Netlify CMS as the headless CMS for editing content.

@barancezayirli barancezayirli requested a review from a team as a code owner January 6, 2020 07:31
@sidharthachatterjee
Copy link
Contributor

@barancezayirli Starters typically have the gatsby-starter- naming convention. Would you like to rename this to follow that?

@barancezayirli
Copy link
Contributor Author

@sidharthachatterjee sure doing now :)

@barancezayirli barancezayirli changed the title chore(starters): add gatsby-resume-tailwind chore(starters): add gatsby-starter-resume-cms Jan 6, 2020
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thank you so much @barancezayirli 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 6, 2020
@barancezayirli
Copy link
Contributor Author

Thank you! @siddhant1

Need to wake up :)
@barancezayirli
Copy link
Contributor Author

barancezayirli commented Jan 6, 2020

@siddhant1 I am trying to figure out why starters_validate is failing (my first assumption was actually it was yaml) but from the script, it is not related. Can you help me out?

@sidharthachatterjee
Copy link
Contributor

@barancezayirli That seems unrelated (appears that npm audit is failing because their API is acting funny, happens occasionally)

Once the rest pass, I'll merge it in anyway 🙂

(Also you tagged the wrong Sid hehe)

@barancezayirli
Copy link
Contributor Author

@sidharthachatterjee I think I am sleeping still 😃 Trying to finish up everything before Christmas brunch sorry for the spamming 😅

@sidharthachatterjee
Copy link
Contributor

@barancezayirli Haha, no worries at all! Have fun!

@sidharthachatterjee sidharthachatterjee merged commit 1326fb4 into gatsbyjs:master Jan 6, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 6, 2020

Holy buckets, @barancezayirli — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants