Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(gatsby-cli): update active NodeJS version #20346

Merged
merged 2 commits into from
Jan 6, 2020
Merged

test(gatsby-cli): update active NodeJS version #20346

merged 2 commits into from
Jan 6, 2020

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Dec 30, 2019

Node.js v11 has been already deprecated and v13 is active now.
Please see https://nodejs.org/en/about/releases/

Description

Documentation

Related Issues

@shisama shisama requested a review from a team as a code owner December 30, 2019 17:12
@shisama shisama changed the title test(gatsby-cli): update active NodeJS version to test NodeJS version. test(gatsby-cli): update active NodeJS version Dec 30, 2019
pvdz
pvdz approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, sure. I don't think removing 11 from this test will make much of a difference but at the same time I guess it can't hurt? :)

Thanks!

@pvdz pvdz merged commit 47d2a8d into gatsbyjs:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shisama @pvdz