Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix broken url to run-sift.js #20304

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Conversation

tcope25
Copy link
Contributor

@tcope25 tcope25 commented Dec 26, 2019

No description provided.

@tcope25 tcope25 requested a review from a team as a code owner December 26, 2019 16:40
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole document is out of date. But I guess fixing broken link still makes sense until we fix the document itself 😃

Thanks for this fix!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 26, 2019
@vladar vladar changed the title fix broken url to run-sift.js fix(docs): fix broken url to run-sift.js Dec 26, 2019
@gatsbybot gatsbybot merged commit abb337b into gatsbyjs:master Dec 26, 2019
@gatsbot
Copy link

gatsbot bot commented Dec 26, 2019

Holy buckets, @tcope25 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@laurieontech
Copy link
Contributor

Hey @vladar, thanks for addressing this one! We're trying to get better at keeping track of stuff that needs updating but gets lost in closed PRs. I've written something up on it here but the gist of it is we're trying to open issues for needed docs changes. Would you be able to open one for this since you appear to have the context? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants