-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commas in code blocks of markdown #20286
Conversation
If not specified, the parameter to Array.join is treated as ',' which resulted in commas being matched as a character that needs to be replaced by `escape-html.js` (but without a replacement specified, it was being rendered as the string 'undefined').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is a funny bug. Thanks for noticing and fixing it! 💜
Holy buckets, @exclipy — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Hello all, How I write in markdown file resolve: How it's rendered in html resolve: Thanks a lot for your support ! |
This PR seems to fix the problem, but there is no version bump. As a result, the fix is not published on npm. |
@vladar Seems to this PR not yet published, Right? |
Published in |
Thanks all for paying attention. Solution; ```javascript |
awesome - just what i was looking for. |
Description
If a comma appeared in a code block in markdown with the Remark/PrismJS plugin, it was being rendered as the string
undefined
. This PR fixes that so commas are now rendered as commas.Documentation
I'll need help with updating the documentation. This bug affects Gatsby's website and it will have to be rebuilt with this fix.
Related Issues
Fixes #20270