Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Jest option setupFilesAfterEnv #20275

Merged
merged 2 commits into from
Dec 23, 2019
Merged

docs: update Jest option setupFilesAfterEnv #20275

merged 2 commits into from
Dec 23, 2019

Conversation

robinmetral
Copy link
Contributor

Description

The Jest option setupTestFrameworkScriptFile has been renamed to setupFilesAfterEnv. The legacy name is deprecated.

Source: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array

This PR updates the option in the Testing CSS-in-JS guide.

Documentation

// noop

Related Issues

None.

@robinmetral robinmetral requested a review from a team as a code owner December 23, 2019 16:54
@vladar
Copy link
Contributor

vladar commented Dec 23, 2019

The doc you linked says that setupFilesAfterEnv must be an array. Did you try this new option? Curious if it will work with string?

@robinmetral
Copy link
Contributor Author

🤦‍♂
Copied over the line from my setup this time - no mistake possible 😛

Nice catch @vladar 🙌

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Looks good to me.

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 23, 2019
@gatsbybot gatsbybot merged commit 705aeed into gatsbyjs:master Dec 23, 2019
@robinmetral robinmetral deleted the docs/update-jest-setupfilesafterenv branch December 23, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants