fix(plugin-netlify-cms): set global window vars required for Gatsby components #20264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladar
approved these changes
Dec 27, 2019
vladar
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19898
Netlify CMS supports registering Gatsby components as preview templates. Some of these components (
gastby-linkin the issue above) use global window variables set here.The CMS plugin bundles the CMS as a separate React app thus needs to set these manually.
I'm stubbing the
___loadersince preloading is not required for the CMS previews.Not sure this is the best approach though.