fix(gatsby-source-contentful): Add contentful_id field recursively #20258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
approved these changes
Dec 22, 2019
sidharthachatterjee
changed the title
contentful_id field recursively in gatsby-source-contentful
|
Published in |
vladar
reviewed
Dec 24, 2019
| } | ||
| if (_.isPlainObject(val)) { | ||
| return fixIds(val) | ||
| } |
There was a problem hiding this comment.
This should account for circular references otherwise we'll get stack overflow errors. Probably also need a test with circular references.
|
This fix broke my code. We use some circular references. Perhaps it should be an option instead of the default? |
|
Correct, I've been able to repro that upgrading to this version causes Maxmimum Callstack issue. |
|
--> #20313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gatsby-source-contentful fixIds method is recursively "fixing" contentful node ids, but only adding a contentful_id field one level deep.
Documentation
Related Issues
Fixes #15426