Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack glossary/enclyclopedia entry #20233

Merged
merged 5 commits into from
Jan 6, 2020
Merged

webpack glossary/enclyclopedia entry #20233

merged 5 commits into from
Jan 6, 2020

Conversation

webinista
Copy link
Contributor

Description

Adds a new documentation page that explains webpack and how Gatsby uses it. Also updates glossary page and sidebar navigation with links to the new page.

@webinista webinista added type: documentation An issue or pull request for improving or updating Gatsby's documentation 🎯 Marketing labels Dec 20, 2019
@webinista webinista requested review from a team as code owners December 20, 2019 00:43
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks once again, Tiffany! The suggestions I've made fall into a couple of categories. The only ones I'd consider must haves are the changes that remove the use of the word "simple" per the Style Guide. Of course, how you do that is totally up to you!

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of small tweaks but this looks good to go!

@AishaBlake AishaBlake added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 6, 2020
@gatsbybot gatsbybot merged commit 74cd158 into gatsbyjs:master Jan 6, 2020
@webinista webinista deleted the docs/webpack branch January 7, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants