Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gatsby-remark-embedder #20205

Merged
merged 5 commits into from
Dec 22, 2019
Merged

Use gatsby-remark-embedder #20205

merged 5 commits into from
Dec 22, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Dec 18, 2019 •
edited
Loading

  • Use gatsby-remark-embedder to handle embedding Twitter & Youtube
  • Replace Twitter embeds with tweet links
  • Replace YouTube embeds with video links
  • Remove gatsby-remark-embed-video dependency, since this can also be done by gatsby-remark-embedder

@MichaelDeBoey MichaelDeBoey requested review from a team as code owners December 18, 2019 23:42
@MichaelDeBoey MichaelDeBoey force-pushed the use-gatsby-remark-embedder branch from efbf04f to 4f2c5cb Compare December 18, 2019 23:50
sidharthachatterjee
sidharthachatterjee approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much for your work on the plugin and for moving us over to it 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 22, 2019
@gatsbybot gatsbybot merged commit a855ff3 into gatsbyjs:master Dec 22, 2019
@MichaelDeBoey
Copy link
Contributor Author

This is amazing, thanks! 🎉

@MichaelDeBoey MichaelDeBoey deleted the use-gatsby-remark-embedder branch December 22, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @sidharthachatterjee @gatsbybot