fix(gatsby-source-drupal): allow specifying disallowed link types #19930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larowlan
previously approved these changes
Dec 3, 2019
|
Thanks folks, newcomer here but all that makes sense - thanks for confirming
…On Tue, Dec 3, 2019, 10:13 PM Matt Glaman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/gatsby-source-drupal/src/gatsby-node.js
<#19930 (comment)>:
> @@ -57,7 +61,7 @@ exports.sourceNodes = async (
})
const allData = await Promise.all(
_.map(data.data.links, async (url, type) => {
- if (type === `self` || type === `describedby`) return
+ if (_.includes(disallowedLinkTypes, type)) return
For what it's worth, I reused lodash here since the file did not know what
node supported. I can update to use the native method. That way new code
slowly move away from lodash
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19930?email_source=notifications&email_token=AAEHR5XLDECIRI7X4GSQDRTQWZEO3A5CNFSM4JURZ672YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNX4UGY#discussion_r353143206>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEHR5WSTEDNIEJJD7O7CYLQWZEO3ANCNFSM4JURZ67Q>
.
|
mglaman
force-pushed
the
mglaman-19921
branch
from
4a70c9d to
bfb1a5f
Compare
|
I miss a documentation in the plugin readme |
mglaman
force-pushed
the
mglaman-19921
branch
from
bfb1a5f to
8d6b379
Compare
|
Added information to the README |
pvdz
suggested changes
Dec 4, 2019
|
|
||
| You can use the `disallowedLinkTypes` option to skip link types found in JSON:API documents. By default it skips the `self` and `describedby` links, which do not provide data that can be sourced. You may override the setting to add additional link types to be skipped. | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
Tip: you can use ```js here ;) But ```javascript also works so it's fine either way.
pvdz
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
disallowedLinkTypessetting that allows you to exclude specific link types.By default it excludes
selfanddescribedby, meeting the current state. This allows skipping link types on/jsonapi. This way someone could exclude certain resource links from being crawled, so it actually allows someone to add performance enhancements when building.I've added a test fixture and test.
Related Issues
Fixes #19921
Relates #19867
Relates #19879