Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): handle case when gatsbyMajorVersion is unset in a starter #19924

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

jamo
Copy link
Contributor

@jamo jamo commented Dec 2, 2019

Seems to fix:

21:36:45 PM: error Building static HTML failed for path "/starters/"
21:36:45 PM: 104 | </span> 105 | <span css={{ display: `flex` }}> > 106 | {gatsbyMajorVersion[0][1] === `2` && ( | ^ 107 | <span 108 | sx={{ 109 | alignItems: `center`, WebpackError: TypeError: Cannot read property '1' of undefined - starter-list.js:106 StartersList.starters.map src/views/starter-library/starter-list.js:106:46 - starter-list.js:63 StartersList src/views/starter-library/starter-list.js:63:19
21:36:46 PM: ERROR Failed to compile: Error: Exited with code 1

Not sure if there is a nicer way to fix this in the query 🙈

@jamo jamo requested a review from a team as a code owner December 2, 2019 20:08
@pieh pieh changed the title Try to fix an issue when gatsbyMajorVersion is unset in a starter fix(www): handle case when gatsbyMajorVersion is unset in a starter Dec 3, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit 693caad into master Dec 3, 2019
@pieh pieh deleted the debug-build branch December 3, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants