fix(gatsby-telemetry): gracefully handle postinstall script permission errors #19920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permission errors. This really is a hack for a bug in npm, but some other packages, including core-js does this hack. To repro: ``` $ docker run --rm -it ubuntu bash $ npm install -g gatsby-cli ``` and it will fail with ``` > [email protected] postinstall /root/.nvm/versions/node/v10.17.0/lib/node_modules/gatsby-cli/node_modules/gatsby-telemetry > node src/postinstall.js sh: 1: node: Permission denied ``` the || true will just make it exit happily, even though we were unable to run the postinstall script.
pieh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really is a hack for a bug in npm, but some other packages,
including core-js does this hack.
To repro:
and it will fail with
the || true will just make it exit happily, even though we were unable
to run the postinstall script.