Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: flatten gatsby-theme dir #19910

Merged
merged 5 commits into from
Dec 4, 2019
Merged

chore: flatten gatsby-theme dir #19910

merged 5 commits into from
Dec 4, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 2, 2019

Description

Related Issues

@pieh pieh added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Dec 2, 2019
@pieh pieh requested review from a team as code owners December 2, 2019 11:22
sidharthachatterjee
sidharthachatterjee reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to rename to gatsby-theme-cli while you're at it?

@pieh
Copy link
Contributor Author

pieh commented Dec 2, 2019

Want to rename to gatsby-theme-cli while you're at it?

I don't want to apply more changes than needed just to fix directory structure, I feel like package name change is out of the scope here?

sidharthachatterjee
sidharthachatterjee previously approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair since this is experimental and will be eventually merged into gatsby-cli

Thanks @pieh 🌮

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 2, 2019
sidharthachatterjee
sidharthachatterjee approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gatsbybot gatsbybot merged commit 916635c into master Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the gatsby-theme-cli-cleanup branch December 4, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieh @sidharthachatterjee @gatsbybot