fix(gatsby-source-drupal): skip jsonapi_schema endpoint #19879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON:API Schema module (https://www.drupal.org/project/jsonapi_schema) adds a `describedby` link to resources. This payload doesn't contain a JSON:API document, but information describing the object's schema. It's not a valid source of content. After debugging, it is the original cause of #19867
pieh
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Yup, makes sense as well ;) Let's get this in!
Question for future: not quite sure how "type" usually looks like, but maybe this could be type whitelist (only handle if link type is one we care about) instead of type blacklist (don't handle this type - "self" and "describedby" in current shape)?
|
@pieh ah, good idea. |
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JSON:API Schema module (https://www.drupal.org/project/jsonapi_schema) adds a
describedbylink to resources. This payload doesn't contain a JSON:API document, but information describing the object's schema. It's not a valid source of content.After debugging, it is the original cause of #19867
Related Issues
Related to #19867