feat(gatsby-plugin-feed): Allows to override default feed url generation

[matyo91]

Description

This add the possibility to configure a custom link for rss meta generation.

[pvdz]

You can pass on output as is :)

[pvdz]

The only remark i see here is // TODO: remove for v3 :

You have a point here! However, I do believe being defensive about a v3 is not what we want here.

Can you please add a test for this feauture? That way, when v3 does arrive and that part of the code gets updated, the test will prompt us to deal with this problem (one way or the other).

With the test you can drop the (redundant) regular expression safely without having to worry about v3 :)

Thanks

[matyo91]

With the test you can drop the (redundant) regular expression safely without having to worry about v3 :)

I added more tests one for the feature and two for prefixes.
I made tests about what is done today for non-regression, not what V3 will be tomorrow.

So i didn't understand why I can in this PR drop regular expression and potentially break other projets using this plugin, as I have no idea if this PR will be released for V2 or for V3.

[pvdz]

Ok nevermind. It's fine. Thanks for the adding the tests, that's super helpful.

Thank you for your effort!

[gatsbot]

Holy buckets, @matyo91 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!