fix(gatsby): use correct state in the schema hot reloader #19862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
previously approved these changes
Nov 29, 2019
|
Oh I'm sorry, I missed the wip label. I would have postponed the review had I noticed it sooner. |
|
Unfortunately, you can't draft an existing PR. And I noticed that e2e tests failing only after created this PR. Thats why using WIP label. |
vladar
force-pushed
the
vladar/e2e-schema-rebuilding
branch
from
e7a1f83 to
07272ee
Compare
sidharthachatterjee
approved these changes
Nov 29, 2019
sidharthachatterjee
added
the
bot: merge on green
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up after #19781. It fixes schema hot reloading which was not handled correctly in the previous PR. It also adds a simple e2e test for schema rebuilding to catch such situations in the future.