[gatsby-plugin-netlify-cms] switch to require.resolve for modules hoisting

[rwu823]

Description

This fix in mono-repo based project the node_modules hoist to project root.

[pvdz]

This is a non-trivial change. Any chance you could add a test for it?

Basically before it would be relative paths (foo/name/assetDir/assetName) and with this change absolute paths are passed through. This could have various subtle implications down the line.

(There's a number of reasons why this change is non-trivial. For example, white/blacklists could be doing a prefix check, those would break with this change.)

Is there an issue about this problem? Seems to me like this would affect many people.

[pvdz]

(Non-trivial change without tests)

[pvdz]

cc @erquhart

[rwu823]

@pvdz

I don't quite understand what you mean and about white/blacklists could be doing a prefix check. But if you don't do this fix how do you resolve the problem I mentioned above?

[pvdz]

@rwu823 I definitely want to help to resolve that issue (can please you point me to the report, or file a new one in https://github.com/gatsbyjs/gatsby/issues/new?template=bug_report.md ?). I also want to make sure that the fix is not going to cause other problems and so I'm asking for a test :)

[erquhart]

This was just added a day ago, looks like the right move. @erezrokah should sign off on it.

[erezrokah]

This looks much better. I'm good with it

[erezrokah]

@pvdz I had recently changed the plugin code to copy the relevant dependencies instead of letting Webpack do the bundling. This fix makes sure the dependencies are resolved from the correct location.

[gatsbot]

Holy buckets, @rwu823 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!