Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update link to using-gatsby-without-graphql example #19726

Merged
merged 1 commit into from
Dec 30, 2019
Merged

fix(docs): update link to using-gatsby-without-graphql example #19726

merged 1 commit into from
Dec 30, 2019

Conversation

aceyoung9
Copy link
Contributor

Description

Two of the examples link to each other, and one of them was renamed; this fixes a lingering dead-link.

Related Issues

Related to #10904, #10782

Thanks!

@aceyoung9 aceyoung9 requested a review from a team as a code owner November 22, 2019 16:57
@aceyoung9 aceyoung9 added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Nov 22, 2019
@laurieontech
Copy link
Contributor

Thanks for the PR and for catching this. Left a couple of comments.

@laurieontech
Copy link
Contributor

Hey @aceyoung9, if we can accept these two changes this is ready to be merged!

@laurieontech laurieontech added the status: awaiting author response Additional information has been requested from the author label Dec 9, 2019
@vladar
Copy link
Contributor

vladar commented Dec 23, 2019

@aceyoung9 This PR got a bit stuck for a while. Could you please check the suggestion of @laurieontech ? If you don't have time to work on this, maybe you can provide access to your fork so that we could continue with it?

@aceyoung9
Copy link
Contributor Author

@vladar @laurieontech Hi, sorry, I will unstick this PR and rebase appropriately in the next 24 hours.

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@vladar vladar added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting author response Additional information has been requested from the author labels Dec 30, 2019
@gatsbybot gatsbybot merged commit d19fe0a into gatsbyjs:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants