-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): Includes ts/tsx files to eslint rules #15976
Conversation
@wardpeet can you please rerun the tests. They failed because of GitHub downtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thank you for taking this on! Looks great!
No comments 👏
Holy buckets, @ashr81 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
This appears to have broken builds of Gatsby sites using Typescript, as they're now expecting TypeScript files to just use JavaScript syntax? Edit: Only in develop mode |
rolled back in [email protected] |
@wardpeet what shall I do to fix this issue? |
I don't think the initial issue was valuable anyways. typescript-eslint is outdated (you now use eslint) and a typical Gatsby project is still JS, not TypeScript. People who want to use TypeScript can probably setup their own eslint setup. |
@LekoArts Ok, Makes sense. |
@ashr81 You have to also move eslint-config-react-app to |
we've reverted the change for now as it seems to give some troubles in monorepos |
Description
Includes ts/tsx files extensions to check for the eslint rules.
Fixes #15114