Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Includes ts/tsx files to eslint rules #15976

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

ashr81
Copy link
Contributor

@ashr81 ashr81 commented Jul 22, 2019

Description

Includes ts/tsx files extensions to check for the eslint rules.

Fixes #15114

@ashr81 ashr81 requested a review from a team as a code owner July 22, 2019 15:29
@ashr81
Copy link
Contributor Author

ashr81 commented Jul 23, 2019

@wardpeet can you please rerun the tests. They failed because of GitHub downtime.

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thank you for taking this on! Looks great!

No comments 👏

@wardpeet wardpeet changed the title Includes ts/tsx files to eslint rules. chore(gatsby): Includes ts/tsx files to eslint rules. Jul 23, 2019
@wardpeet wardpeet changed the title chore(gatsby): Includes ts/tsx files to eslint rules. feat(gatsby): Includes ts/tsx files to eslint rules. Jul 23, 2019
@wardpeet wardpeet changed the title feat(gatsby): Includes ts/tsx files to eslint rules. feat(gatsby): Includes ts/tsx files to eslint rules Jul 23, 2019
@wardpeet wardpeet merged commit 6adcb9a into gatsbyjs:master Jul 23, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 23, 2019

Holy buckets, @ashr81 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@me4502
Copy link
Contributor

me4502 commented Jul 24, 2019

This appears to have broken builds of Gatsby sites using Typescript, as they're now expecting TypeScript files to just use JavaScript syntax?

Edit: Only in develop mode

wardpeet added a commit that referenced this pull request Jul 24, 2019
@wardpeet
Copy link
Contributor

rolled back in [email protected]

@ashr81
Copy link
Contributor Author

ashr81 commented Jul 24, 2019

@wardpeet what shall I do to fix this issue?

@LekoArts
Copy link
Contributor

I don't think the initial issue was valuable anyways. typescript-eslint is outdated (you now use eslint) and a typical Gatsby project is still JS, not TypeScript. People who want to use TypeScript can probably setup their own eslint setup.

@ashr81
Copy link
Contributor Author

ashr81 commented Jul 24, 2019

@LekoArts Ok, Makes sense.

@ThewBear
Copy link
Contributor

@ashr81 You have to also move eslint-config-react-app to ^4.0.0 for typescript support otherwise it will fail all typescript files.

@wardpeet
Copy link
Contributor

we've reverted the change for now as it seems to give some troubles in monorepos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eslint-config-react-app to ^4.0.0
5 participants