-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-sass): Accept css-loader options #9462
feat(gatsby-plugin-sass): Accept css-loader options #9462
Conversation
@pieh Need anything else from me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left a few comments, my biggest concern is about the snapshots, but doesn't look like you'd have done anything to break that so just want to double check!
packages/gatsby-plugin-sass/src/__tests__/__snapshots__/gatsby-node.js.snap
Show resolved
Hide resolved
packages/gatsby-plugin-sass/src/__tests__/__snapshots__/gatsby-node.js.snap
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dustinhorton!
Holy buckets, @dustinhorton — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
v2 changed how dashes/hyphens in class names handled by css modules were treated: gatsbyjs#5458. This was burdensome as it required changing all `className`s that utilized dashes. This allows overriding that change, almost entirely by copying prior art from @yeskunall & @pieh (gatsbyjs#9237).
v2 changed how dashes/hyphens in class names handled by css modules were treated: #5458. This was burdensome as it required changing all
className
s that utilized dashes.This allows overriding that change, almost entirely by copying prior art from @yeskunall & @pieh (#9237).