Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: add gatsby-plugin-cxs #8710

Closed
DSchau opened this issue Oct 2, 2018 · 7 comments
Closed

[feat]: add gatsby-plugin-cxs #8710

DSchau opened this issue Oct 2, 2018 · 7 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby

Comments

@DSchau
Copy link
Contributor

DSchau commented Oct 2, 2018

Summary

CXS is a great library for CSS in JS w/ React. Let's create a plugin so that others can get some SSR benefits and CSS hydration with Gatsby.

Motivation

  • We have a number of other plugins which implement similar functionality, e.g. gatsby-plugin-emotion, gatsby-plugin-styled-components, etc.
  • We don't want to prohibit anyone from using Gatsby because their preferred styling solution isn't supported, and Gatsby is extremely pluggable to enable this :)

General Approach

  • Create packages/gatsby-plugin-cxs (see previously mentioned CSS in JS libraries for more info/boilerplate)
  • Implement the SSR API from Aphrodite
  • PR and experience the ❤️ from all of those who use and like Cxs
@DSchau DSchau added Hacktoberfest good first issue Issue that doesn't require previous experience with Gatsby labels Oct 2, 2018
@ctxhou
Copy link
Contributor

ctxhou commented Oct 3, 2018

Is this issue taken? If not, I would like to work on this 😄

@DSchau
Copy link
Contributor Author

DSchau commented Oct 3, 2018

@ctxhou we'd love for you to take it if you're able! Looking forward to the PR, and let any of us @gatsbyjs/core know if we can help!

@tbaustin
Copy link

tbaustin commented Oct 5, 2018

@ctxhou have you completed this or do you need help?

@ctxhou
Copy link
Contributor

ctxhou commented Oct 6, 2018

Hi @tbaustin, I am working on this!
I will send the pull request later 😄

@amberleyromo
Copy link
Contributor

Hi @ctxhou! Still working on this?

@ctxhou
Copy link
Contributor

ctxhou commented Oct 30, 2018

hey @amberleyromo, I've send the PR and wait for review 😄

@DSchau
Copy link
Contributor Author

DSchau commented Nov 6, 2018

This was done in #8878. Thanks @ctxhou!

@DSchau DSchau closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby
Projects
None yet
Development

No branches or pull requests

5 participants