feat(gatsby,gatsby-script): Do not use context for script collection #36246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: core
tyhopp
changed the title
tyhopp
force-pushed
the
feat-no-context-script-collection
branch
from
3a438aa to
735a6d1
Compare
wardpeet
reviewed
Jul 29, 2022
packages/gatsby/src/internal-plugins/partytown/gatsby-browser.tsx
Outdated
Show resolved
Hide resolved
wardpeet
reviewed
Jul 29, 2022
packages/gatsby/src/internal-plugins/partytown/gatsby-browser.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby/src/internal-plugins/partytown/gatsby-browser.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby/src/internal-plugins/partytown/gatsby-browser.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby/src/internal-plugins/partytown/utils/inject-partytown-snippet.ts
Outdated
Show resolved
Hide resolved
tyhopp
force-pushed
the
feat-no-context-script-collection
branch
from
f24d77d to
43b5006
Compare
Co-authored-by: Ward Peeters <[email protected]>
tyhopp
commented
Aug 1, 2022
e2e-tests/development-runtime/playwright/gatsby-script-off-main-thread.spec.ts
Show resolved
Hide resolved
wardpeet
reviewed
Aug 1, 2022
packages/gatsby/src/internal-plugins/partytown/gatsby-browser.tsx
Outdated
Show resolved
Hide resolved
LekoArts
previously approved these changes
Aug 2, 2022
wardpeet
reviewed
Aug 2, 2022
LekoArts
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes use of React context when collecting
off-main-threadscripts to configureforwardson a per-page basis.It also:
headinstead of thebody(as the Partytown docs instruct)Documentation
Updates the limitations section of the script component
off-main-threadstrategy docs. No limitation is added with this PR, instead it documents an existing limitation that is missing from the docs and links to the Partytown repo.Related Issues
[sc-53628]