feat(gatsby-script): Duplicate script callbacks if no injected script callbacks #35717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script has no callbacks
gatsbot
bot
added
the
status: triage needed
tyhopp
removed
the
status: triage needed
tyhopp
changed the title
pieh
approved these changes
May 23, 2022
pieh
deleted the
feat-script-component-duplicate-script-callbacks-no-first
branch
pieh
pushed a commit
that referenced
this pull request
May 23, 2022
… callbacks (#35717) * refactor(gatsby-script): Only dedupe if id or src exists * test(gatsby-script): Add waitForRouteChange on visits * feat(gatsby-script): Execute duplicate script callbacks even if first script has no callbacks * chore(gatsby-script): Add comment about listener behavior * feat(gatsby-script): Adjust remove event listener logic (cherry picked from commit f91f477)
pieh
pushed a commit
that referenced
this pull request
May 23, 2022
… callbacks (#35717) (#35723) Co-authored-by: Ty Hopp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
waitForRouteChangeto allcy.visitcalls in script component tests because it seems to help reduce flakes when Cypress moves too fast before the page finishes loadingDocumentation
N/A
Related issues
[sc-50935]