-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): DSG support for FS routes #33697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb255cf
to
6938ae5
Compare
pieh
reviewed
Oct 29, 2021
pieh
reviewed
Oct 29, 2021
pieh
reviewed
Oct 29, 2021
pieh
reviewed
Oct 29, 2021
pieh
reviewed
Oct 29, 2021
pieh
reviewed
Oct 29, 2021
Co-authored-by: Michal Piechowiak <[email protected]>
Co-authored-by: Michal Piechowiak <[email protected]>
pieh
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it ;)
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
* initial scaffolding to make it work * Support `graphql` queries in the `config` function * Support `graphql` tag in config queries * fix ts * some tests for config queries * use `graphql` tagged template literal to run queries * Update packages/gatsby/src/utils/page-mode.ts Co-authored-by: Michal Piechowiak <[email protected]> * Update packages/gatsby/src/utils/page-mode.ts Co-authored-by: Michal Piechowiak <[email protected]> * test two queries in one file * rephrase TODO comment * revert unneeded change Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: render-mode
Related to Gatsby's different rendering modes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for DSG config for FS routes.
Caveat: it only runs in
gatsby build
right now. So there is no way to debug it in develop. Wiring it up to develop will be a follow-up. The reason why this is not a priority is that DSG indevelop
has no effect anyways.Usage example
Say you have a template
src/pages/posts/{MarkdownRemark.fields__slug}.js
(using FS routes), then you can optionally mark some of the pages created with this template as defer using the following code:[ch38465]