-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-recipes] Remove duplicate Babel install #31023
Comments
Thanks for the suggestion @aaronadamsCA Are you up to opening a PR with this change? |
I'd be able to find the references and remove and replace the dependency. Let me know if I could work on this if you both prefer. Thanks! |
Hi, I had some time tonight and went ahead and completed the issue. Hope it saves you time from doing it yourself. Just submitted a PR for review. Thanks! |
The opened PR is invalid now (as the fork was deleted) so we're still open to PRs! |
I will take this up :) |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Hey again! It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Thanks again for being part of the Gatsby community! 💪💜 |
Retitled to clarify why this should be done. Seems the existing PR is dead, so @LekoArts I can try picking this up myself. |
Cool! |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Not stale. I think #32377 should be fine despite the failing tests, since I'm pretty sure that's just intermittent failure (likely because Yarn v1 is broken/dead and rarely builds a valid dependency tree). But if anyone else sees anything to add, please comment! |
taking up on this issue |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Happy to update the PR if someone can commit to review and merge before it goes stale again :) |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Hey again! It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Thanks again for being part of the Gatsby community! 💪💜 |
Actually our goal is to remove |
Yes, absolutely. Thanks for confirming, then! Let me know if there's anything I could do to help with that initiative. |
The package
remark-mdxjs
is deprecated and no longer being published:https://github.com/mdx-js/mdx/tree/main/packages/remark-mdxjs
According to its README its behaviour is now included in
remark-mdx
.remark-mdxjs
had an unranged outdated@babel/core
dependency. The result is an entire second Babel install when installing Gatsby.I think these lines should all be safely removable:
gatsby/packages/gatsby/package.json
Line 241 in df3f184
gatsby/packages/gatsby-recipes/package.json
Line 53 in df3f184
gatsby/packages/gatsby-recipes/package.json
Line 122 in df3f184
gatsby/packages/gatsby-recipes/src/parser/index.js
Line 3 in 54d4721
gatsby/packages/gatsby-recipes/src/parser/index.js
Line 54 in 54d4721
There are probably other references to the package to clean up as well.
The text was updated successfully, but these errors were encountered: