Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-recipes] Remove duplicate Babel install #31023

Closed
aaronadamsCA opened this issue Apr 23, 2021 · 19 comments
Closed

[gatsby-recipes] Remove duplicate Babel install #31023

aaronadamsCA opened this issue Apr 23, 2021 · 19 comments
Labels
help wanted Issue with a clear description that the community can help with. topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) type: bug An issue or pull request relating to a bug in Gatsby

Comments

@aaronadamsCA
Copy link
Contributor

aaronadamsCA commented Apr 23, 2021

The package remark-mdxjs is deprecated and no longer being published:

https://github.com/mdx-js/mdx/tree/main/packages/remark-mdxjs

According to its README its behaviour is now included in remark-mdx.

remark-mdxjs had an unranged outdated @babel/core dependency. The result is an entire second Babel install when installing Gatsby.

I think these lines should all be safely removable:

"remark-mdxjs": "^2.0.0-next.3"

"remark-mdxjs": "^2.0.0-next.4",

"remark-mdxjs": "^2.0.0-next.4"

import remarkMdxjs from "remark-mdxjs"

There are probably other references to the package to clean up as well.

@aaronadamsCA aaronadamsCA added the type: bug An issue or pull request relating to a bug in Gatsby label Apr 23, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 23, 2021
@vladar vladar added help wanted Issue with a clear description that the community can help with. topic: recipes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 26, 2021
@vladar
Copy link
Contributor

vladar commented Apr 26, 2021

Thanks for the suggestion @aaronadamsCA Are you up to opening a PR with this change?

@jithenms
Copy link

I'd be able to find the references and remove and replace the dependency. Let me know if I could work on this if you both prefer. Thanks!

@jithenms
Copy link

Hi, I had some time tonight and went ahead and completed the issue. Hope it saves you time from doing it yourself.

Just submitted a PR for review. Thanks!

@LekoArts
Copy link
Contributor

LekoArts commented May 3, 2021

The opened PR is invalid now (as the fork was deleted) so we're still open to PRs!

@Harshita-Kanal
Copy link

I will take this up :)

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 28, 2021
@LekoArts LekoArts added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed topic: recipes labels May 28, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@github-actions github-actions bot closed this as completed Jul 8, 2021
@aaronadamsCA aaronadamsCA changed the title [gatsby-recipes] Remove remark-mdxjs dependency [gatsby-recipes] Remove duplicate Babel install Jul 8, 2021
@aaronadamsCA
Copy link
Contributor Author

Retitled to clarify why this should be done. Seems the existing PR is dead, so @LekoArts I can try picking this up myself.

@LekoArts
Copy link
Contributor

LekoArts commented Jul 8, 2021

Cool!

@LekoArts LekoArts reopened this Jul 8, 2021
@LekoArts LekoArts removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 8, 2021
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 28, 2021
@aaronadamsCA
Copy link
Contributor Author

Not stale.

I think #32377 should be fine despite the failing tests, since I'm pretty sure that's just intermittent failure (likely because Yarn v1 is broken/dead and rarely builds a valid dependency tree). But if anyone else sees anything to add, please comment!

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Aug 14, 2021
@amitsin6h
Copy link

taking up on this issue

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 9, 2021
@aaronadamsCA
Copy link
Contributor Author

Happy to update the PR if someone can commit to review and merge before it goes stale again :)

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 10, 2021
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 30, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@github-actions github-actions bot closed this as completed Nov 9, 2021
@aaronadamsCA
Copy link
Contributor Author

@LekoArts / @vladar , could you reopen?

Happy to redo the PR anytime, but last time it just sat there unreviewed until it was stale, so I'd like to know it'll get merged before I take the time again :)

@LekoArts LekoArts removed the stale? Issue that may be closed soon due to the original author not responding any more. label Nov 10, 2021
@LekoArts
Copy link
Contributor

Actually our goal is to remove gatsby-recipes completely so at quick glance this should solve it, too, right?

@aaronadamsCA
Copy link
Contributor Author

Yes, absolutely. Thanks for confirming, then! Let me know if there's anything I could do to help with that initiative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
6 participants