fix(gatsby-plugin-mdx): fix html field resolver to work with webpack@5 #30158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: MDX
topic: webpack/babel
None of our e2e tests use mdx so I would need to do full setup or add it to |
|
@pieh we have two that do. mdx and mdx-less-babel |
laurieontech
approved these changes
Mar 10, 2021
vladar
added a commit
that referenced
this pull request
Mar 10, 2021
#30158) (#30172) Cherry-picked from 0a6c6eb Co-authored-by: Michal Piechowiak <[email protected]>
|
Published in |
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
htmlfield in gatsby-plugin-mdx was not working due its usage of webpack and not migrating it to work withwebpack@5:asset.source()was just not working anymore, because it was alreadySizeOnlySourcethat we can only grab size stats from (ref https://webpack.js.org/blog/2020-10-10-webpack-5-release/#sizeonlysource-after-emit )nodeexternals preset resulted in various module likestreamorutilnot being availableThis changes how it currently work to straight import produced file (similar as we do in core for ssr rendering) and skip messing with compilation object to grab source and then materialize/evaluate it (and using additional webpack plugin just for that)
Related Issues
Fixes #29983