Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Remove possibility to use global graphql tag for queries #29291

Merged
merged 4 commits into from
Feb 10, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Feb 1, 2021

Description

This replaces the warn with a panic for global GraphQL tags. Until now people were able to use the graphql tag for queries without explicitly importing it from Gatsby (import { graphql } from 'gatsby').

Of course, using a graphql tag from another library (e.g. relay) should still work and not thrown an error. The tests will ensure this.

Documentation

Related Issues

[ch23981]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 1, 2021
@LekoArts LekoArts added topic: GraphQL Related to Gatsby's GraphQL layer topic: internal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 1, 2021
@LekoArts LekoArts marked this pull request as ready for review February 2, 2021 10:04
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I've added a question

@wardpeet wardpeet changed the title gatsby: Remove possibility to use global graphql tag for queries feat(gatsby): Remove possibility to use global graphql tag for queries Feb 10, 2021
@LekoArts LekoArts merged commit d933462 into master Feb 10, 2021
@LekoArts LekoArts deleted the v3/graphql-function branch February 10, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants