fix(gatsby-plugin-sass): Nest sassOptions #28683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
pieh
reviewed
Dec 18, 2020
pieh
reviewed
Dec 18, 2020
pieh
reviewed
Dec 18, 2020
pieh
previously approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In my testing for #27754 I didn't catch the breaking change of
sass-loadernow nesting the options intosassOptions. This also does this now.Also fixed #28278
Since the new major of
gatsby-plugin-sassis only published on thenextbranch we were able to catch that there.Documentation
Looked through our docs, couldn't find any mention of sass options, so only changed the README