fix(gatsby-plugin-sass): loosely check postCssPlugins #27829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: sass
and removed
status: triage needed
laurieontech
approved these changes
Nov 4, 2020
|
This is awesome; thank you for the quick fix! Any chance of this getting merged/pushed soon? This issue is causing some large negative effects for me right now. Thanks again! |
This was referenced Nov 5, 2020
|
Thanks for the fix! Ran into this issue just now. |
|
Bumping up this, as it is a blocker for everyone right now. |
hargwit
added a commit
to hargwit/hargwit.com
that referenced
this pull request
Nov 12, 2020
|
Test failures are unrelated, they're flaky tests: #27781 Merging! |
|
Sorry for the delay on merging this! |
vladar
pushed a commit
that referenced
this pull request
Nov 13, 2020
(cherry picked from commit ac37599)
vladar
added a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27825
Instead of trying to validate the entire postcss plugin system, we should just let postcss do that itself. The test I edited failed before this PR and passes after.