Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sass): add missing options #27786

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

mikaelkristiansson
Copy link
Contributor

Description

cssLoaderOptions is not defined in the schema, so it will return an error when passing in these options.
See readme:

If you need to override the default options passed into css-loader: Note: Gatsby is using [email protected].

plugins: [
  {
    resolve: `gatsby-plugin-sass`,
    options: {
      cssLoaderOptions: {
        camelCase: false,
      },
    },
  },
]

`cssLoaderOptions` is not defined in the schema, so it will return an error when passing in these options.
See readme: 
```
If you need to override the default options passed into css-loader: Note: Gatsby is using [email protected].

plugins: [
  {
    resolve: `gatsby-plugin-sass`,
    options: {
      cssLoaderOptions: {
        camelCase: false,
      },
    },
  },
]
```
@mikaelkristiansson mikaelkristiansson requested a review from a team as a code owner November 2, 2020 15:15
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 2, 2020
@LekoArts LekoArts added topic: sass and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 2, 2020
mxstbr
mxstbr previously approved these changes Nov 2, 2020
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!! 💯

@mxstbr mxstbr added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 2, 2020
mxstbr
mxstbr previously approved these changes Nov 2, 2020
@mikaelkristiansson
Copy link
Contributor Author

@mxstbr did I miss some kind of tests or why is it failing?

@gatsbybot gatsbybot merged commit 7c86973 into gatsbyjs:master Nov 3, 2020
@mikaelkristiansson mikaelkristiansson deleted the patch-1 branch November 3, 2020 08:18
@pvdz
Copy link
Contributor

pvdz commented Nov 3, 2020

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants