fix(babel-plugin-remove-graphql-queries): Strip ignored characters from query text for better caching and deduping #24807

sidharthachatterjee · 2020-06-05T11:27:36Z

This strips spaces and comments from query text before hashing them so that

{
  site {
    siteMetadata {
      github
    }
  }
}

is the same as

            {
              site {
                siteMetadata {
                  github
                }
              }
            }

This will lead to better caching and query reuse 🙂

blainekasten

Looks great to me!

…om query text for better caching and deduping (#24807) * Strip ignored characters from query text for better caching and deduping * Update snapshots

…om query text for better caching and deduping (gatsbyjs#24807) * Strip ignored characters from query text for better caching and deduping * Update snapshots

Strip ignored characters from query text for better caching and deduping

7e1f313

sidharthachatterjee requested a review from a team as a code owner June 5, 2020 11:27

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 5, 2020

sidharthachatterjee added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 5, 2020

Update snapshots

5fa373b

blainekasten approved these changes Jun 5, 2020

View reviewed changes

blainekasten merged commit 752f5ff into master Jun 5, 2020

delete-merged-branch bot deleted the fix/normalised-query-text branch June 5, 2020 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(babel-plugin-remove-graphql-queries): Strip ignored characters from query text for better caching and deduping #24807

fix(babel-plugin-remove-graphql-queries): Strip ignored characters from query text for better caching and deduping #24807

sidharthachatterjee commented Jun 5, 2020 •

edited

Loading

blainekasten left a comment

fix(babel-plugin-remove-graphql-queries): Strip ignored characters from query text for better caching and deduping #24807

fix(babel-plugin-remove-graphql-queries): Strip ignored characters from query text for better caching and deduping #24807

Conversation

sidharthachatterjee commented Jun 5, 2020 • edited Loading

blainekasten left a comment

Choose a reason for hiding this comment

sidharthachatterjee commented Jun 5, 2020 •

edited

Loading