Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spelling of "e-commerce" consistent across the site #20790

Closed
1 task
AishaBlake opened this issue Jan 22, 2020 · 6 comments · Fixed by #22566
Closed
1 task

Make spelling of "e-commerce" consistent across the site #20790

AishaBlake opened this issue Jan 22, 2020 · 6 comments · Fixed by #22566
Assignees
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@AishaBlake
Copy link

AishaBlake commented Jan 22, 2020

Summary

We're using a mix of spellings of the word "e-commerce" across the site. The biggest issue this causes arises when someone tries to search the term. If you use "ecommerce" in the search bar, you'll get results from the blog before results from the documentation.

search results for the term ecommerce showing blog posts and then docs

Motivation

We use "e-commerce" and we should be consistent throughout the site.

Steps to resolve this issue

  • Search through the docs for alternate spellings of "e-commerce" and correct them!

Open a pull request

@AishaBlake AishaBlake changed the title Make spelling of Make spelling of "e-commerce" consistent across the site Jan 22, 2020
@marcysutton marcysutton added status: inkteam assigned type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Jan 22, 2020
@kingisaac95
Copy link

@bball07 are you still looking into this? If not, I can take it on as my first issue to resolve

bball07 pushed a commit that referenced this issue Jan 25, 2020
Fixed spelling of "e-commerce" as described in issue #20790
bball07 pushed a commit that referenced this issue Jan 25, 2020
closes #20790 in the pull request description
bball07 pushed a commit that referenced this issue Jan 25, 2020
Fixed spelling of "e-commerce" as described in issue #20790
@AishaBlake
Copy link
Author

@kingisaac95 I appreciate you asking before submitting a PR, particularly since this was originally assigned to a specific person! You may want to check issues with the "help wanted" label for potential first PRs if you haven't already.

@AishaBlake AishaBlake reopened this Feb 14, 2020
@AishaBlake
Copy link
Author

Looks like we still have several lingering instances of spellings other than "e-commerce". Personally, I'm less concerned about changing URLs/filenames than I am about making sure the text uses the correct spelling.

@marcysutton
Copy link
Contributor

@AishaBlake do you know if have the remaining instances been solved yet? Maybe we could close this issue now?

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 20, 2020
@AishaBlake
Copy link
Author

They haven't been solved. We had two sort of related PRs last month that only addressed a couple of instances each. I'm going to add it to the backlog and get it done in a batch next week.

I think it also makes sense to alter the search behavior if we can. Reading the Algolia documentation on replacing words, I'm thinking we treat e-commerce and ecommerce as synonyms in case people are trying to search on "ecommerce". Since that would have to happen internally, I'll add it to our backlog for now.

@AishaBlake AishaBlake added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Mar 22, 2020
@Ekwuno Ekwuno self-assigned this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants