You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think you are missing child/parent relationship cases, so when child/parent relationship is added either through action or by setting 'parent' field.
We usually test against .org (www folder in monorepo) using gatsby-dev-cli. You can test against multiple sites using develop-runner. You need to modify source code a bit, but it's still very handy.
We often publish a pre-release version for packages with big changes, then you can use it to test with develop-runner. Eg you can reuse tag @schema-customization. (To do it, go to gatsby/packages/gatsby and do yarn publish --tag schema-customization).
should we also add some notes about develop-runner - i only found this description here #19092 (review)
I'm not sure - we ourselves use this pretty rarely, only when there is rewrite of one of major core function that potentially could introduce bugs (or unforeseen breaking changes). Last time we used it (before schema rebuilding PR) was materialization for data layer.
The script itself also takes a loong time to run, so I don't want to force it on contributors, as it's not needed for most of PRs.
It makes sense to me to make a note about it somewhere, but this could be separate PR to not scope creep this one?
The text was updated successfully, but these errors were encountered:
Hi, thanks for the issue!
I don't think the motivation you listed would outweigh the possible negative impacts of mentioning this somewhere.
Most if not all PRs that contributors other than the core team don't touch code that would need that test runner. Plugin developers also use well tested public APIs that don't need that runner. Lastly, mentioning this somewhere would make the impression that this tool could be necessary or is even stable.
Maybe once this is a more fleshed out solution that is actually usable by normal contributors we could revisit that. For now I'd want to close this.
Summary
add a note about
developer-runner
because this gem is somewhere hidden in the issues and not documentedMotivation
Steps
Doc snippets
i found this doc snippets as a start:
comment 1 #19092 (review)
comment 2 #19349 (comment)
The text was updated successfully, but these errors were encountered: