Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-sass): Add ability to override sassRuleTest and sassRuleModulesTest #16494

Merged
merged 5 commits into from
Aug 9, 2019
Merged

feat(gatsby-plugin-sass): Add ability to override sassRuleTest and sassRuleModulesTest #16494

merged 5 commits into from
Aug 9, 2019

Conversation

tkbky
Copy link
Contributor

@tkbky tkbky commented Aug 9, 2019 •
edited by sidharthachatterjee
Loading

Description

This PR adds 2 new options to gatsby-plugin-sass

  • sassRuleTest to configure regex for sass files.
  • sassRuleModulesTest to configure regex for css modules files.

Related Issues

Fixes #15879

tkbky added 2 commits August 9, 2019 22:56
@tkbky
Add a configuration for sass plugin file regexes
fe84d30 
Add 2 new options for gatsby-sass-plugin
- `sassRuleTest` to configure regex for sass files.
- `sassRuleModulesTest` to configure regex for css modules files.

Refer gatsbyjs#15879 for motivation
behind this addition.
@tkbky
Update README
8a208ea 
with guide to override file regex for sass and css modules.
@tkbky tkbky requested review from a team as code owners August 9, 2019 15:17
@tkbky tkbky mentioned this pull request Aug 9, 2019
Closed
@sidharthachatterjee sidharthachatterjee changed the title [gatsby-plugin-sass] Add config for sass plugin file regex feat(gatsby-plugin-sass): Add ability to override sassRuleTest and sassRuleModulesTest Aug 9, 2019
@sidharthachatterjee sidharthachatterjee dismissed abumalick’s stale review August 9, 2019 21:58

Not relevant in the example

sidharthachatterjee
sidharthachatterjee previously approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for adding this @tkbky 👍

sidharthachatterjee
sidharthachatterjee previously approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

sidharthachatterjee
sidharthachatterjee approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 9, 2019
@gatsbybot gatsbybot merged commit df209d9 into gatsbyjs:master Aug 9, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 9, 2019

Holy buckets, @tkbky — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sidharthachatterjee
Copy link
Contributor

Published in [email protected]

@tkbky
Copy link
Contributor Author

tkbky commented Aug 9, 2019

Thanks @sidharthachatterjee

@abumalick abumalick mentioned this pull request Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@abumalick abumalick abumalick left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-sass] Add a configuration for sass plugin file regexes
4 participants
@tkbky @sidharthachatterjee @abumalick @gatsbybot