-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-offline): Change navigation handler logic #13502
Merged
gatsbybot
merged 30 commits into
gatsbyjs:master
from
vtenfys:offline-check-page-resources
Aug 8, 2019
Merged
fix(gatsby-plugin-offline): Change navigation handler logic #13502
gatsbybot
merged 30 commits into
gatsbyjs:master
from
vtenfys:offline-check-page-resources
Aug 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@davidbailey00 I'm going to close this for now. Let's come back and re-open it once you're back in (Gatsby) action! |
vtenfys
commented
Aug 8, 2019
sidharthachatterjee
suggested changes
Aug 8, 2019
packages/gatsby-cli/src/reporter/reporters/ink/components/develop.js
Outdated
Show resolved
Hide resolved
sidharthachatterjee
previously approved these changes
Aug 8, 2019
sidharthachatterjee
previously approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Let's ship this 👍
sidharthachatterjee
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more "stable" part of #11965
Changes:
resetWhitelist
API withclearPathResources
, which clears the page resource dependenciesRationale: using the path whitelist turned out to be buggy, especially during upgrades when files could be in inconsistent state. Many of the initial bugs were fixed, but some of the fixes are more workarounds than proper solutions which can still result in temporary white screen flashes.
Therefore these changes should be more reliable, since by checking the main bundle is present as well as the required resource files, we can be more sure that the latest essential files are cached rather than just looking at a list.