fix(gatsby): correctly replace exported queries for StaticQuery #11545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the static query extraction (rather the import statement) failing when the query is `export`ed. The issue was that the AST was expected to be at a certain depth (e.g. the .parentPath stuff), and we need to go up _one_ more level to get the correct element we expected, i.e. the component. Fixes gatsbyjs#11477
DSchau
commented
Feb 4, 2019
| @@ -76,12 +83,12 @@ function removeImport(tag) { | |||
| else importPath.remove() | |||
| } | |||
| if (importPath.isObjectProperty()) { | |||
| if (parent.node.properties.length === 1) | |||
| importPath.findParent(p => p.isVariableDeclaration())?.remove() | |||
There was a problem hiding this comment.
These were causing eslint to go wild. I lightly refactored this and used a helper.
|
I used this example to validate this PR. Doesn't seem to cause any regressions as best as I can tell, just fixes the bug. |
|
Nice! Hopefully this is the main bug that people keep hitting with static queries. |
|
@KyleAMathews I think this is one of them. The other is the one that @tkh44 @jlengstorf seem to be intermittently hitting, i.e. something like I think that's a monorepo/workspaces bug though, not necessarily something with StaticQuery. Still need to research it more though. |
pieh
approved these changes
Feb 4, 2019
|
DSchau
deleted the
babel-plugin-remove-graphql-queries/export-static-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the static query extraction (rather the import statement)
failing when the query is
exported. The issue was that the AST wasexpected to be at a certain depth (e.g. the .parentPath stuff), and we
need to go up one more level to get the correct element we expected,
i.e. the component.
I also added an e2e test to guard against this behavior in the future.
Related Issues
Fixes #11477