Skip to content
This repository has been archived by the owner on Oct 31, 2020. It is now read-only.

Project should have a .gitignore file. #18

Open
vyasriday opened this issue Sep 29, 2020 · 9 comments · May be fixed by #27 or #33
Open

Project should have a .gitignore file. #18

vyasriday opened this issue Sep 29, 2020 · 9 comments · May be fixed by #27 or #33

Comments

@vyasriday
Copy link

I think there should be a .gitignore file to exclude contents of node_modules and other files that should not be part of git.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.74. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@garimasingh128
Copy link
Owner

Node modules aren't a part of the project already. There was a gitignore present.

@vyasriday
Copy link
Author

Actually when I tried to check my changes i saw node_modules added and couldn't see the .gitignore.

@garimasingh128
Copy link
Owner

u saw node modules before doing npm install?

@vyasriday
Copy link
Author

No they are not there as I can see node_modules is not available in repo as well. But there is no .gitignore as well, as you can in the repo. Perhaps somebody didn't push it.

@garimasingh128
Copy link
Owner

Alright. Let me know if you want to be assigned!

@vyasriday
Copy link
Author

Okay, I can fix it. You can assign me.

@rajatjain-21 rajatjain-21 linked a pull request Sep 30, 2020 that will close this issue
14 tasks
@vyasriday vyasriday linked a pull request Sep 30, 2020 that will close this issue
11 tasks
@vyasriday
Copy link
Author

@garimasingh128 Added PR specific to a react project.

@Cronus1007
Copy link

Let me work on this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants