Remove support for consul service registry (istio#25833)

* Remove support for consul service registry

* remove test and comments for consul

Author: Shamsher Ansari

.gitignore

@@ -34,9 +34,6 @@ bin/protoc-gen-docs*
 bin/testlinter
 bin/envvarlinter
 bin/istioctl
-# Install generated files
-install/consul/istio.yaml
-samples/bookinfo/platform/consul/bookinfo.sidecars.yaml
 *.orig
 # Avoid accidental istio.VERSION changes
 istio.VERSION

codecov.threshold

@@ -22,7 +22,6 @@ istio.io=5
 
 # Overrides
 istio.io/istio/pilot/pkg/config/memory/monitor.go=30
-istio.io/istio/pilot/pkg/serviceregistry/consul/monitor.go=20
 istio.io/istio/pilot/cmd/pilot-agent/status/server.go=61
 istio.io/istio/pkg/mcp/creds/watcher.go=100
 istio.io/istio/pkg/mcp/source/client_source.go=90

install/consul/README.md

@@ -630,19 +630,6 @@ func TestBuildStatPrefix(t *testing.T) {
 			},
 			"reviews.namespace1.7443",
 		},
-		{
-			"Service from non k8s registry",
-			"%SERVICE%.%SERVICE_PORT%",
-			"reviews.hostname.consul",
-			"",
-			&model.Port{Name: "grpc-svc", Port: 7443, Protocol: "GRPC"},
-			model.ServiceAttributes{
-				ServiceRegistry: serviceregistry.External,
-				Name:            "foo",
-				Namespace:       "bar",
-			},
-			"reviews.hostname.consul.7443",
-		},
 		{
 			"Service FQDN only pattern",
 			"%SERVICE_FQDN%",

install/consul/consul_config/agent-loglevel.json

@@ -118,7 +118,7 @@ func (c *Controller) Services() ([]*model.Service, error) {
 		// may modify one of the service's cluster ID
 		clusterAddressesMutex.Lock()
 		if r.Cluster() == "" { // Should we instead check for registry name to be on safe side?
-			// If the service does not have a cluster ID (consul, ServiceEntries, CloudFoundry, etc.)
+			// If the service does not have a cluster ID (ServiceEntries, CloudFoundry, etc.)
 			// Do not bother checking for the cluster ID.
 			// DO NOT ASSIGN CLUSTER ID to non-k8s registries. This will prevent service entries with multiple
 			// VIPs or CIDR ranges in the address field
@@ -168,7 +168,7 @@ func (c *Controller) GetService(hostname host.Name) (*model.Service, error) {
 			continue
 		}
 		if r.Cluster() == "" { // Should we instead check for registry name to be on safe side?
-			// If the service does not have a cluster ID (consul, ServiceEntries, CloudFoundry, etc.)
+			// If the service does not have a cluster ID (ServiceEntries, CloudFoundry, etc.)
 			// Do not bother checking for the cluster ID.
 			// DO NOT ASSIGN CLUSTER ID to non-k8s registries. This will prevent service entries with multiple
 			// VIPs or CIDR ranges in the address field

install/consul/consul_config/agent.json

@@ -24,7 +24,7 @@ type Instance interface {
 	model.Controller
 	model.ServiceDiscovery
 
-	// Provider backing this service registry (i.e. Kubernetes, Consul, etc.)
+	// Provider backing this service registry (i.e. Kubernetes etc.)
 	Provider() ProviderID
 
 	// Cluster for which the service registry applies. Only needed for multicluster systems.