Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write "correct" error message on quota issues into machine lastoperation message #72

Open
nschad opened this issue Oct 12, 2022 · 0 comments
Labels
kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@nschad
Copy link

nschad commented Oct 12, 2022

What happened:

Could also be an Enhancement. Anyway.

When trying to create a machine with an already exceeded OpenStack instance quota, the machine immediately goes into CrashLookBackOff as the volume of said machine can not be deleted. This is kinda expected as the instance wasn't created in the first place and volume also already is gone. The problem is that in the machine object the following message is written:

DELETE https:/mycinder.com:443/v3/<server>/volumes/<VOLUME_ID>], error message: {"badRequest": {"code": 400, "message": "Invalid volume: Volume status must be available or error or error_restoring or error_ extending or error_managing and must not be migrating, attached, belong to a group, have snapshots or be disassociated from snapshots after volume transfer."}}.

Why is this needed:

The message in the machine object is confusing for the operator. The real "error message" (quota exceeded) is only shown in the logs.

What you expected to happen:

On quota errors we should write the quota error into the machine object last operation message. Maybe we should also consider having an extra state in k8s for this i.e. QuotaExceeded.

How to reproduce it (as minimally and precisely as possible):

  1. Have full/exceeded openstack quota instances
  2. Try to create a new machine (scale-up)

Anything else we need to know:

Environment:
Gardener: 1.53.4
mcm: 0.46.1

@nschad nschad added the kind/bug Bug label Oct 12, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 21, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants