Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Releases #12

Open
nithssh opened this issue Oct 5, 2024 · 2 comments
Open

Firefox Releases #12

nithssh opened this issue Oct 5, 2024 · 2 comments

Comments

@nithssh
Copy link

nithssh commented Oct 5, 2024

Hey,

This extension is already fully compatible with Firefox when tested, and only needs to be released for Firefox along with chrome.

According to the porting guide, it isn't recommended to make any changes to the code if the only changes required are browser API namespace changes ('chrome' -> 'browser'), which happens to be the only required changes here.

For abstracting over these API namespace differences there is a CLI tool by Mozilla called web-ext. We only need to go into the repo's directory, and run web-ext build and it will emit a .zip file with these browser abstractions made, which you can then publish. You can even test this zip in chrome, and if it works (which it should), you can unzip it and upstream those abstractions into the codebase if you like.

Would you please consider release management for Firefox along with chrome too? There are currently ~96 users of the Firefox 'fork', I can transfer the ownership of that Addons store listing to you. Sorry about the pointless fork, I was a highschooler who didn't understand How to Open Source at that time. I was looking into upstreaming it and realized there is nothing to upstream. You only need to do releases management.

Please let me know what you think about this. Thanks!

Nithish

@nithssh
Copy link
Author

nithssh commented Oct 5, 2024

Here is a patch for a minor manifest change that is required for Firefox. You can find more details in the commit message.

0001-Add-Firefox-specific-IDs-mandated-for-V3-extensions.patch.txt

@ganigeorgiev
Copy link
Owner

I don't have a sandboxed VM prepared at the moment to download random files.

I'll consider publishing a Firefox version in the future, but there are no ETAs.

If you have already published a Firefox extension port, to make the eventual future transition easier you can try to give your extension a distinct/unique name (e.g. appending "port" or something else) so that it doesn't conflict with the used name in the current manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants