Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimal pool liquidity #1008

Open
jak-pan opened this issue Jan 30, 2025 · 0 comments
Open

Fix minimal pool liquidity #1008

jak-pan opened this issue Jan 30, 2025 · 0 comments

Comments

@jak-pan
Copy link
Contributor

jak-pan commented Jan 30, 2025

I think this check was supposed to check the shares left after withdrawal to stop you from being locked out as there is similar check in XYK if I remember correctly.

However, this won't prevent it as you can just send shares away. This means we can end up in a state where there is enough shares in a pool but there is not enough shares in anybody's account to actually withdraw anything. I think the solution to this is to tie the minimal pool balances/shares to existential deposit.

This should be viable thing after we implement #1007

However this number probably shouldn't change. I would consider setting it to the fallback values so we don't end up in the same situation.

Originally posted by @jak-pan in #1003 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant