Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(etherscan): url params naming #911

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Feb 14, 2022

Motivation

URL Params naming was incorrect according to
https://docs.etherscan.io/tutorials/verifying-contracts-programmatically#4.-configuring-source-code-parameters

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Comment on lines +20 to +21
#[serde(rename = "contractname")]
pub contract_name: String,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contract_name is now required, refer to the link in the description

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@gakonst gakonst merged commit a8cdfe6 into gakonst:master Feb 14, 2022
@rkrasiuk rkrasiuk deleted the fix/etherscan-url-params branch February 14, 2022 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants