Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

remove unofficial testnet dai #771

Merged
merged 1 commit into from
Jan 7, 2022
Merged

remove unofficial testnet dai #771

merged 1 commit into from
Jan 7, 2022

Conversation

nikozalo
Copy link
Contributor

@nikozalo nikozalo commented Jan 7, 2022

Official rinkeby support for MCD has been deprecated a long time ago. Furthermore the rinkeby address in this library is not even a dai.sol implementation - not sure who deployed or maintains this instance.
Instead I would encourage users to utilize the official goerli MCD instance, and the related Dai token for testing, which I have added in this commit.

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Official rinkeby support for MCD has been deprecated a long time ago. Furthermore the rinkeby address in this library is not even a dai.sol implementation - not sure who deployed or maintains this instance.
Instead I would encourage users to utilize the official goerli MCD instance, and the related Dai token for testing, which I have added in this commit.
@gakonst gakonst merged commit 24fd7e1 into gakonst:master Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants