Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat(solc): add more contract utility types and functions #765

Merged
merged 3 commits into from
Jan 7, 2022
Merged

feat(solc): add more contract utility types and functions #765

merged 3 commits into from
Jan 7, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 6, 2022

Motivation

Add various helper types for dealing with contract's bytecodes

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse mentioned this pull request Jan 6, 2022
Merged
gakonst
gakonst approved these changes Jan 7, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - feels like we should do a pass at the entire package once we're a bit stabler on Foundry and see if we have duplicate logic / if we can simplify / take the package on a diet as it's starting to get quite big I think

ethers-solc/src/artifacts.rs Outdated Show resolved Hide resolved
ethers-solc/src/artifacts.rs Outdated Show resolved Hide resolved
mattsse and others added 2 commits January 7, 2022 12:40
@mattsse
Copy link
Collaborator Author

mattsse commented Jan 7, 2022

yeah, the artifacts.rs needs another pass even if it's just moving types to a separate file, it's coming in at 2k sloc rn which is a bit much.
should at least extract all contract related types

@gakonst gakonst merged commit d54d381 into gakonst:master Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst