Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Stabilize Remappings auto detection #728

Closed
mattsse opened this issue Dec 23, 2021 · 0 comments · Fixed by #732
Closed

Stabilize Remappings auto detection #728

mattsse opened this issue Dec 23, 2021 · 0 comments · Fixed by #732

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 23, 2021

detecting Remappings is intended to support node_modules as well as dapptools style libraries.

While dapptools' lib folder follows some general rules (directories named lib and src), the average node_modules dependency might not, common patterns are

node_modules/<dep>/lib.sol
node_modules/<dep>/contracts/lib.sol
node_modules/<dep>/{tokens,auth,...}/{contracts, interfaces}/lib.sol
node_modules/<dep>/contracts/{tokens,auth,..}/lib.sol

It's also common that these are nested (especially for dapptools)
lib/ds-token/lib/ds-stop/lib/ds-note/src/contract.sol

Detection needs to be fast (especially for node_modules) and deterministic

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant