This repository was archived by the owner on Oct 19, 2024. It is now read-only.
fix: contract creation on trezor #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
suggested changes
Dec 15, 2021
ethers-signers/src/trezor/types.rs
Outdated
Comment on lines
78
to
83
| // Contract Creation | ||
| if value.is_empty() { | ||
| "".to_string() | ||
| } else { | ||
| unimplemented!() | ||
| } |
There was a problem hiding this comment.
think we should just be erroring here if a user passes an ENS name instead of silently letting it through in the empty case or panicking if it's not empty?
gakonst
approved these changes
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To create a contract, it's required to pass the
toaddress as an empty string.Solution
toas an empty stringIt should show on the device:
PR Checklist