This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: replace FilterStream with concrete type #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the provider by reference and explicitly calling
get_filter_changes
inside the future impl we're able to simplify the function signature for anything involvingFilterWatcher
.This allows us to remove the
FilterStream
helper trait (which was used to have simpler function signatures).