This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
removes an assert! that would cause a panic if the project was previously built with hardhat.
it is not required that the format ids match and is currently used to provide a way to distinguish whether the file was previously built with hardhat.
I'm not sure what the most straight forward approach to remove possible friction between ethers-solc/foundry builds and hardhat would be
possible solutions:
MinimalCombinedArtifactsHardhatFallback
artifact output the default which supports reading hardhat style artifactsSolution
PR Checklist