Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: remove assert to check cache format #689

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 13, 2021

Motivation

removes an assert! that would cause a panic if the project was previously built with hardhat.

it is not required that the format ids match and is currently used to provide a way to distinguish whether the file was previously built with hardhat.

I'm not sure what the most straight forward approach to remove possible friction between ethers-solc/foundry builds and hardhat would be

possible solutions:

  • always check for matching ethers format id, treat cache as empty if it was written by hardhat
  • use a different cache file than hardhat
  • keep it like it is and make MinimalCombinedArtifactsHardhatFallback artifact output the default which supports reading hardhat style artifacts

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse force-pushed the matt/fix-file-cache branch from 7070adf to 1aed940 Compare December 13, 2021 23:05
@gakonst gakonst merged commit 4bb2636 into gakonst:master Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants