This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
ci: test on windows targets #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/ci-windows-build
branch
2 times, most recently
from
a84a3db to
27fd2c1
Compare
gakonst
approved these changes
Dec 12, 2021
mattsse
force-pushed
the
matt/ci-windows-build
branch
4 times, most recently
from
f89d7f3 to
eb977bb
Compare
gakonst
reviewed
Dec 12, 2021
| @@ -222,3 +222,53 @@ jobs: | |||
| run: | | |||
| export PATH=$HOME/bin:$PATH | |||
| ./scripts/examples.sh | |||
|
|
|||
| windows-build: | |||
There was a problem hiding this comment.
Might be worth putting this in a different workflow file?
There was a problem hiding this comment.
but I'm a little hesitant to move this out, perhaps we can leverage all the geth, ganach stuff and unify everything in a matrix build with all vars etc, like I've attempted here foundry-rs/foundry#218
|
Blocked on alloy-rs/svm-rs#9 getting merged / new release |
gakonst
force-pushed
the
matt/ci-windows-build
branch
from
eb977bb to
de49986
Compare
gakonst
approved these changes
Dec 13, 2021
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Dec 13, 2021
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Build on windows targets in CI.
But only builds, for tests, need to figure out how to install ganache and geth on windows
Solution
PR Checklist